gitsome 0.8.0 (new formula)

[smorimoto]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[smorimoto]

For reasons similar to dvc, we use this installation method because some features doesn't work with the common installation method of brew.

[smorimoto]

The actual error was posted here. donnemartin/gitsome#136

[smorimoto]

I will add code to install Pillow to support image-related features.

[fxcoudert]

We really want to have dependencies listed as resources, and install them.

[smorimoto]

I have same opinion with that, and I tried. But an error like the one I posted to issue of gitsome will occur.

[fxcoudert]

pkg_resources.DistributionNotFound: The 'uritemplate.py<4.0.0,>=1.0.0' distribution was not found and is required by gitsome

This means you need to include the right version of uritemplate as a resource. Look at https://github.com/tdsmith/homebrew-pypi-poet

[smorimoto]

Hmm...

resource "uritemplate" do
  url "https://files.pythonhosted.org/packages/cd/db/f7b98cdc3f81513fb25d3cbe2501d621882ee81150b745cdd1363278c10a/uritemplate-3.0.0.tar.gz"
  sha256 "c02643cebe23fc8adb5e6becffe201185bf06c40bda5c0b4028a93f1527d011d"
end

resource "uritemplate.py" do
  url "https://files.pythonhosted.org/packages/12/97/e12695c7d7710143767022ce931061b4a6b5b19982b20ecf5d71cdde3da1/uritemplate.py-3.0.2.tar.gz"
  sha256 "e0cdeb0f55ec18e1580974e8017cd188549aacc2aba664ae756adb390b9d45b4"
end

[smorimoto]

https://gist.github.com/imbsky/f483f91b031c681ba54443db3ebc7cbc

[fxcoudert]

Have you figured out why uritemplate.py is not actually found?

[smorimoto]

I found a similar issue, but I don't know if it's related.
SFDO-Tooling/CumulusCI#883

[smorimoto]

I have identified the cause, probably I need to change the gitsome code a little. The difficulty is low, but if @donnemartin doesn't have much time, I and my friend can fix it.

[smorimoto]

@donnemartin What do you think?

[fxcoudert]

We need a test that exercises the some of the functionality of the app. Version checks or usage checks (foo --version or foo --help) are not sufficient, as explained in the formula cookbook.

In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.

• Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)
• You can also check that an output file was created, if that is expected: assert_predicate testpath/"output.txt", :exist?

Some advice for specific cases:

• If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.
• If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.
• If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.
• Same if the software requires a virtual machine, docker instance, etc. to be running.

[Bo98]

Let us know when you've addressed the concerns above.

For now, we're currently building Python 3.8 (see #45337), which involves revision bumping almost all Python formulae, so we're going to wait on this until that's finished to avoid broken formulae. I'll let you know when we're ready.

[smorimoto]

I see. This is an upstream issue, so I will wait for the author's reply.

[fxcoudert]

Closing for now, due to lack of progress.