Skip to content

portable-ruby 3.4.3 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

portable-ruby 3.4.3 #306

merged 1 commit into from
Apr 16, 2025

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Apr 15, 2025

Created by brew bump


Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

Co-authored-by: Bo Anderson <[email protected]>
@Bo98 Bo98 force-pushed the bump-portable-ruby-3.4.3 branch from e4e52fe to 8683278 Compare April 15, 2025 03:36
@Bo98 Bo98 mentioned this pull request Apr 15, 2025
1 task
@Bo98
Copy link
Member

Bo98 commented Apr 15, 2025

Not sure when we're actually ready to pull the trigger here - will require migrating vendored gems to 3.4 in brew and making sure everything works ok (since, from experience, reverting vendored gems changes is usually very messy and best avoided so we'll want to fix forward). Usually do a minor release but on reflection seems like we maybe will be able to get away without one this time if we wanted. Definitely mattered back when we did 2.6 -> 3.1.x as that required formulae changes in some cases and larger system Ruby shifts.

It is a breaking change for formulae if they use any of these: https://rubyreferences.github.io/rubychanges/3.4.html#default-gems-that-became-bundled, though we'll handle Base64 at least given that's probably the main one used there.

The build now works though at least. I've not forwarded patches upstream yet but they are trivial and I will do so later this week.

@Bo98
Copy link
Member

Bo98 commented Apr 15, 2025

Extra considerations for brew:

@Bo98
Copy link
Member

Bo98 commented Apr 15, 2025

Will need to check if this is a problem: https://rubyreferences.github.io/rubychanges/3.4.html#reserved-module-ruby
for: https://github.com/Homebrew/homebrew-core/blob/master/Formula/r/ruby.rb.

While loading the file directly will omit warnings, the way Formulary loads into a dynamic namespace should avoid this problem but worth checking.

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid mentioned that he wanted it to coincide with the release of Homebrew v4.5.0. I think that makes sense.

  • Vendor base64?

I think I handled that in Homebrew/brew@7504258, but let me know if there's anything else I may have missed.

@Bo98
Copy link
Member

Bo98 commented Apr 15, 2025

Ah right, the TODO just needs removing from here then: https://github.com/Homebrew/brew/blob/0046519c08cd3967e0934c82195361ac7e76c567/Library/Homebrew/api.rb#L7

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid mentioned that he wanted it to coincide with the release of Homebrew v4.5.0. I think that makes sense.

Works for me. I'll plan 4.5 🔜.

@p-linnane p-linnane merged commit 8a885b5 into master Apr 16, 2025
9 checks passed
@p-linnane p-linnane deleted the bump-portable-ruby-3.4.3 branch April 16, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants