Replace removable constants with overridable methods #1257
+2
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduugg
commented
Oct 5, 2024
|
|
||
| module Homebrew | ||
| class TestCleanup | ||
| include Kernel |
There was a problem hiding this comment.
It shouldn't be necessary include Kernel in a class (Class is a subclass of Object, which includes Kernel… 🤕)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve failing checks in Homebrew/brew#18517
These PRs need to merged together to work. (I can also update the linked PR to support both constants and methods as an intermediate step.)