Skip to content

new environments! RADIOACTIVE, FROSTBITE #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yonichanowitz
Copy link

added two new environments. tested with multiverse plugin.
tested with space suit and environment module
tested "inside " ship or building

further testing may be required

player.addPotionEffect(PotionEffect(PotionEffectType.POISON, 200 , 1))
player.addPotionEffect(PotionEffect(PotionEffectType.NAUSEA, 200, 1))

player.sendMessage("Suffering Radiation Poisoning!!!")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of sending a message which will spam players chat, try sending an action bar with player.alertAction()

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed it. There are only a few worlds that will be radioactive for now, so the players should know

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not send a message per tick, that will cause the player to receive 20 messages a second, which will cause the player to time out. Please consider using the player.alertAction() instead or another suitable alternative

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sorry I see now you've removed that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Environments are not ticked 20 times per second

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants