refactor: extract color constants into src/colors.js - #56
refactor: extract color constants into src/colors.js#56saumya-30-verma wants to merge 2 commits into
Conversation
|
@saumya-30-verma is attempting to deploy a commit to the houssemeddinechaouch's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Thanks for opening this PR @saumya-30-verma! Before we review, please make sure:
A maintainer will review it soon. 🙌 |
|
I've completed the requested refactor. When you have time, I'd really appreciate your feedback. Thank you! |
HoussemEddineChaouch
left a comment
There was a problem hiding this comment.
Hey @saumya-30-verma, good start, the colors.js
extraction is the right direction 🙌
Two files are missing, help.js and llm.js still have
hardcoded ANSI color codes and weren't updated to
import from colors.js. Please update both to import
from colors.js to keep it consistent across the
whole codebase.
|
Thanks for the review! I've updated help.js and llm.js to use the shared color constants from colors.js and pushed the requested changes. Please let me know if there's anything else to update. |
What does this PR do?
This PR extracts ANSI colour constants into a dedicated
src/colors.jsmodule and updates the existing files to use the shared constants instead of hardcoded ANSI escape sequences.Type of change
How to test it
npm installnode src/index.jsAgent Thinking,Reason, andChoosing tool) is displayed as before.Related issues
Closes #43