Skip to content

Add new HTTP Error codes handling in RetryMiddlewareFactory.php #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zzgael
Copy link

@zzgael zzgael commented Dec 30, 2024

New RetryMiddleware HTTP Error Codes Handling

  • 504 is removed from the list to allow for a retry in case of server failure.
  • range 520-599 is added in order to allow for new codes like the 525 Cloudflare one.
  • Range 505-511 still considered as an exception without retry.
  • a new function to handle multiple ranges has been added while keeping retro-compatibility
  • Default max retries has been refactored into a class constant

New RetryMiddleware HTTP Error Codes Handling 
- 504 is removed from the list to allow for a retry in case of server failure.
- range 520-599 is added in order to allow for new codes like the 525 Cloudflare one.
- Range 505-511 still considered as an exception without retry.
- a new function to handle multiple ranges has been added while keeping retro-compatibility
@ksvirkou-hubspot
Copy link
Collaborator

Could you change the visibility of all private constants and methods to protected within the class, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants