Feature: Add JSON schema validation for projects#280
Merged
Conversation
kemmerle
requested review from
TanyaScales,
brandenrodgers,
camden11 and
joe-yeager
kemmerle
changed the title
Member
|
Hi! Going to look at this as soon as I can -- also cc @joeyblake @tenas97 and @Aaronm14 for visibility on this change |
joe-yeager
reviewed
May 5, 2025
camden11
reviewed
May 6, 2025
This was referenced May 7, 2025
TanyaScales
approved these changes
May 8, 2025
Member
TanyaScales
left a comment
TanyaScales
left a comment
There was a problem hiding this comment.
LGTM from the extension standpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
This PR adds schema validation for HubSpot project components' JSON configuration files. More information is available in the Canvas I posted in Slack yesterday (Message me for access).
Relies on https://git.hubteam.com/HubSpot/project-parsing-lib/pull/20. I've created an experimental tag of PPL to ease testing.
Screenshots
Validation in the
app-hsmeta.jsonfile:Validation in a
card-hsmeta.jsonfile:TESTING
I would use the north star project to test out the schema validation. You can follow the instructions in the contributing guide to run the project locally.
TODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager @TanyaScales