Skip to content

Permute compound list#193

Draft
Bisaloo wants to merge 3 commits intodevelfrom
permute-compound
Draft

Permute compound list#193
Bisaloo wants to merge 3 commits intodevelfrom
permute-compound

Conversation

@Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Jan 29, 2026

Fix #192

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 48.64865% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.16%. Comparing base (83260e4) to head (c4ac4df).

Files with missing lines Patch % Lines
src/H5D.c 48.64% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #193      +/-   ##
==========================================
- Coverage   77.32%   77.16%   -0.17%     
==========================================
  Files          70       70              
  Lines        6544     6581      +37     
==========================================
+ Hits         5060     5078      +18     
- Misses       1484     1503      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Bisaloo
Copy link
Member Author

Bisaloo commented Feb 6, 2026

The breaking change here can potentially impact the following projects: https://github.com/search?q=%2FcompoundAsDataFrame%5Cs*%3D%5Cs*F%2F&type=code

@Bisaloo
Copy link
Member Author

Bisaloo commented Feb 6, 2026

Detected while running revdepcheck on https://github.com/animovement/aniread. The approach proposed here only if we can have a compound data type of homogeneous types since we're trying to create a list of vectors.

The more general case can have different types in a single element and requires returning a list of list.

@Bisaloo Bisaloo marked this pull request as draft February 6, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

h5read for structured data types behaves differently than in h5py.

1 participant