Draft
Conversation
Move to API with token type
Release notes say: > - Remove H5I_REFERENCE from the library > > This ID class was never used by the library and has been removed. https://github.com/HDFGroup/hdf5/blob/9b290ab389b9b560c32e751d0c92f2687a731b8e/release_docs/HISTORY-1_10_0-1_12_0.txt#L252C1-L254C72
Co-authored-by: LTLA <infinite.monkeys.with.keyboards@gmail.com>
Co-authored-by: LTLA <infinite.monkeys.with.keyboards@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #197 +/- ##
==========================================
- Coverage 77.32% 77.24% -0.09%
==========================================
Files 70 71 +1
Lines 6544 6433 -111
==========================================
- Hits 5060 4969 -91
+ Misses 1484 1464 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bisaloo
commented
Feb 19, 2026
Comment on lines
4
to
23
|
|
||
| SEXP Rval; | ||
| const char *file_name = CHAR(STRING_ELT(_file_name, 0)); | ||
| int fd = -1; | ||
| int lk = -1; | ||
|
|
||
| /* create the temporary file */ | ||
| fd = HDopen(file_name, O_RDWR | O_CREAT | O_TRUNC, 0666); | ||
| H5FD_t* fd = H5FDopen(file_name, H5F_ACC_CREAT, H5P_DEFAULT, /* maxaddr, max 1 MB file? */ 1000000); | ||
|
|
||
| /* try to lock file */ | ||
| lk = HDflock(fd, LOCK_EX | LOCK_NB); | ||
| herr_t lk = H5FDlock(fd, /* rw = */ 1); | ||
|
|
||
| /* unlock so we can remove */ | ||
| HDflock(fd, LOCK_UN); | ||
| H5FDunlock(fd); | ||
|
|
||
| /* close */ | ||
| HDclose(fd); | ||
| H5FDclose(fd); | ||
|
|
||
| /* return value of lock attempt */ | ||
| PROTECT(Rval = allocVector(INTSXP, 1)); |
Member
Author
There was a problem hiding this comment.
I think we can use H5Pget_file_locking() in HDF5 >= 1.12.1 for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.