ome_zarr as an S4 class and extending ImageArray - #48
Open
Artur-man wants to merge 17 commits into
Open
Conversation
Artur-man
marked this pull request as draft
August 7, 2026 20:30
Artur-man
marked this pull request as ready for review
August 12, 2026 17:17
Bisaloo
reviewed
Aug 19, 2026
Comment on lines
+52
to
+58
| S4Vectors::new2( | ||
| "ome_zarr", | ||
| levels = S4Vectors:::new_SimpleList_from_list("ImageList", x), | ||
| scales = scales, | ||
| metadata = list(version = ome_version, type = type, dim_names = dim_names) | ||
| ) | ||
| class(x) <- "ome_zarr" | ||
| attr(x, "type") <- type | ||
| attr(x, "version") <- ome_version | ||
| if (!is.null(dim_names)) { | ||
| attr(x, "dim_names") <- dim_names | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This is inconsistent with the definition in AllClasses.R, isn't it?
Member
There was a problem hiding this comment.
The function names are very confusing here. Can we do better than this?
Artur-man
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #36.
Some notes:
ome_zarrclassversion,metadata