Skip to content

One new optional feature and one bug fix #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wbierman wants to merge 2 commits into
base: master
Choose a base branch
from
Open

One new optional feature and one bug fix #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca3a168
Added option to delay motion notification until snapshot available
wbierman Dec 9, 2025
8f1cbd7
Fixed logic in initializing dingable devices
wbierman Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/apps/unofficial-ring-connect.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,8 @@ def mainPage() {
paragraph('<b style="font-size: 22px;">Reset Compromised OAuth Access Token</b>')
paragraph('<b style="color: red;">Do not toggle this button without understanding the following.</b> Resetting this token will require you to manually update <b>ALL</b> of the URLs in any existing dashboard tile any IFTTT applet. There is no need to reset the token unless it was compromised.')
input name: "tokenReset", type: "bool", title: "Toggle this to reset your app's OAuth token", defaultValue: false, submitOnChange: true
paragraph('Enabling this will <b>DELAY</b> motion event notifications until a snapshot is available from the triggering device.')
input name: "delayMotion", type: "bool", title: "Delay motion events until snapshot ready", defaultValue: false, submitOnChange: true
}

donationPageSection()
Expand Down Expand Up @@ -483,7 +485,19 @@ void processIFTTT() {
}

if (kind == "motion") {
d.handleMotion(json)
if (delayMotion) {
logDebug "Delaying motion for ${json.id} until snapshot is ready json ${json} type ${json.class}"

final Integer deviceId = getRingDeviceId(json.id).toInteger()
state.pendingMotion = state.pendingMotion ?: [:]
state.pendingMotion[deviceId] = json // store the event payload

// Request snapshot immediately
apiRequestSnapshotTimestamps([deviceId])
} else {
logDebug "Immediate motion trigger for ${json.id}"
d.handleMotion(json)
}
} else if (kind == "ding") {
d.handleDing(json)
} else {
Expand Down Expand Up @@ -614,7 +628,7 @@ def uninstalled() {
}

void setupDingables() {
state.dingables = getChildDevices()?.findAll { RINGABLES.contains(it.getDataValue("kind")) }?.collect { getRingDeviceId(it.deviceNetworkId) }
state.dingables = getChildDevices()?.findAll { DINGABLES.contains(it.getDataValue("kind")) }?.collect { getRingDeviceId(it.deviceNetworkId) }
}

void configureDingPolling() {
Expand Down Expand Up @@ -1278,6 +1292,16 @@ void apiRequestSnapshotImages(final Map data) {
byte[] retval = new byte[resp.data.available()]
resp.data.read(retval)
state.snapshots[getFormattedDNI(localDoorbotId)] = retval
final String idString = doorbotId.toString()
def pending = state.pendingMotion?.get(idString)
if (pending) {
logDebug "Releasing delayed motion event for ${doorbotId} pending ${pending} type ${pending.class}"
state.pendingMotion.remove(idString)
ChildDeviceWrapper d = getChildDeviceInternal(pending.id)
d.handleMotion(pending)
} else {
logDebug "No pending event for ${doorbotId}"
}
}
}
}
Expand Down