Remove video intro spoke #228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Contributor
Author
|
Oops, not sure I did the branch thing correctly. :( |
Contributor
Author
|
The "Removes videos from setup creating" should have been a separate PR and now is. But I don't know of a safe way (yet) to remove it from here. |
What: Removes video demonstrating the architecture kit from the Introduction, Building Scenes with Spoke, intro-spoke, page. Why: Video needs to be removed as part of Mozilla Branding removal project.
hobbs-Hobbler
force-pushed
the
remove-video-intro-spoke
branch
from
a938d47 to
78911c5
Compare
Contributor
Author
|
@Exairnous helped me fix this. We rebased, in interactive mode, working with the last 5 commits and dropped 4 unneeded commits. Then we rebased the branch on the latest master. Voila. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes architecture-kit.mp4 video from intro-spoke page by deleting the HTML code.
Why?
Part of Mozilla branding removal project.
Limitations
Currently, I believe the architecture kit is not externally facing for the Hubs community newbie users. Showing how to use a resource that is not easily available is not suitable for an introduction-type of page.
Alternatives considered
Video could be remade.
Open questions
Was removal the request here?