Add NPM minimum release age of 7 days#6577
Conversation
Exairnous
left a comment
There was a problem hiding this comment.
Thank you for the PR.
Generally I think this looks good. I was able to get similar results to what you got with the testing steps.
Have you tested building/running hubs with Node 24? If that works, then we should update it in this PR and note the new version in the readme.
Do you know if this affects the Admin Panel as well?
the Admin Panel requires a separate .npmrc file, which I've included in the latest commit
Everything runs and builds fine for me with Node 24, so I've set that as the minimum. |
Exairnous
left a comment
There was a problem hiding this comment.
Aside from the one inline comment, the test-and-deploy-storybook workflow fails with this PR when I pushed the branch to my fork (it fails in the npm ci step), even if I merge the zizmor PR into it to update the setup-node action. Does this happen for you as well?
|
On this branch, using Node.js v24, In CI, it fails at the The zizmor branch does run Let's handle the zizmor PR first, then see if this issue still manifests. |
Why: to guard against supply-side attacks
Co-authored-by: Exairnous <mythologylover75@gmail.com>
…& npm so it's enforced Why: to guard against supply-chain attacks
904f648 to
b4d9b9c
Compare
|
NPM has a bug where setting min release age in more than one place conflicts, so let's set this aside until NPM is fixed: |
What?
Add NPM minimum release age of 7 days
Why?
to guard against supply-side attacks
Examples
n/a
How to test
npm outdated > /tmp/outdated-wonpm outdated > /tmp/outdated-withdiff /tmp/outdated-wo /tmp/outdated-withObserve that now, some of the "wanted" and/or "latest" versions are lower than before.On April 27, I got:
I checked on NPM, and version 7.73.1 of react-hook-form was released one week ago
Documentation of functionality
n/a
Limitations
NPM >= v11.10.0 must be installed for this to be effective
Alternative implementations considered
none
Open questions
none
Additional details or related context
none