Skip to content

Fix: prevent null account_id when creating identity from Accounts UI #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HussainAther wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: prevent null account_id when creating identity from Accounts UI #6579

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d2dda7
Fix: prevent null account_id when creating identity from Accounts UI
HussainAther May 2, 2026
8911f58
Fix: guard missing record.id in IdentityCreateLink and correct JSX
HussainAther May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions admin/src/react-components/fields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,17 +178,35 @@ AvatarLink.propTypes = {
};

export const IdentityEditLink = withStyles(styles)(({ record = {}, classes }) => (
<a href={`#/identities/${record.id}`} className={classes.fieldLink}>
Edit Identity
</a>
));

export const IdentityCreateLink = withStyles(styles)(({ record, classes }) => (
<a href={`#/identities/create?account_id=${record.id}`} className={classes.fieldLink}>
<a href={`#/identities/create?account_id=${record.id}`} className={classes.fieldLink}>
Create Identity
</a>
) : (

@DougReeder DougReeder May 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not syntactically correct JavaScript

@HussainAther HussainAther May 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty. Fixed the JSX syntax issue and simplified the guard for missing record.id.

Also updated the test steps for clearer reproduction.

<span className={classes.disabledLink}>Create Identity</span>
));

if (!record?.id) {
console.warn("Missing record.id for IdentityCreateLink");
}

export const IdentityCreateLink = withStyles(styles)(({ record, classes }) => {
if (!record || !record.id) {
console.warn("IdentityCreateLink: missing record.id", record);
return (
<span className={classes.fieldLink} style={{ opacity: 0.5, cursor: "not-allowed" }}>
Create Identity
</span>
);
}

return (
<a href={`#/identities/create?account_id=${record.id}`} className={classes.fieldLink}>
Create Identity
</a>
);
});


SceneLink.propTypes = {
source: PropTypes.string.isRequired,
record: PropTypes.object,
Expand Down