Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sequencing_run_batch field in sequence_file. Fixes #1557 #1558

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

arschat
Copy link
Member

@arschat arschat commented Apr 29, 2024

Release notes

For sequence_file.json schema:

  • sequencing_run_batch

Why are these changes needed?

Tier 1 metadata have a field to record the sequencing run batch.

Reviews requested

This is a minor schema changes, all DCP2 reviewers need to review

@arschat arschat changed the title Added sequencing_run_id field in sequence_file. Fixes #1557 Added sequencing_run_batch field in sequence_file. Fixes #1557 Jun 20, 2024
Copy link
Collaborator

@ESapenaVentura ESapenaVentura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arschat arschat merged commit d5e4782 into staging Jul 15, 2024
3 of 5 checks passed
@arschat arschat deleted the ac-sequencing-run-Issue1557 branch July 15, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants