-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added collection_institute in specimen_from_organism.Fix#1606 #1607
base: staging
Are you sure you want to change the base?
Conversation
…nto ac-collection-site-Issue1606
"description": "Institute where the biomaterial was collected on.", | ||
"type": "string", | ||
"user_friendly": "Collection site", | ||
"example": "52.175013, 0.141645; site_1; Addenbrooke's Hospital", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commas and semicolon are a bad smell. They represent separators that form a proprietary language (as in CS) to combine several values in one. JSON already has mechanisms for structuring data so why not use those.
This should be a module (a schema for a nested object) with three properties. Longitude, lattitude and name/description. That way you can express additional syntactical constraints on each of them and express their optionality/nullability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback. Created a module in a663ec1
@@ -117,6 +117,13 @@ | |||
} | |||
] | |||
}, | |||
"collection_site": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds a lot like anatomical site. Is there a way to name this new property without that ambiguity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, changed to collection_institute
in 28882ff
Release notes
#1606
For
specimen_from_organism.json
schema:collection_site
Reviews requested