Skip to content

Changed body_mass_index type to allow ranges Fixes#1624 #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arschat wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

Changed body_mass_index type to allow ranges Fixes#1624 #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e66acb4
Merge pull request #1617 from HumanCellAtlas/staging
arschat Apr 29, 2025
d48ad20
Added range option in BMI
arschat Sep 1, 2025
2681607
Update bmi max limit to 199
arschat Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/jsonBrowser/module.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ Location: module/biomaterial/human_specific.json

Property name | Description | Type | Required? | Object reference? | User friendly name | Allowed values | Example
--- | --- | --- | --- | --- | --- | --- | ---
body_mass_index | The body mass index of the donor. | number | no | | Body mass index | | 36.4
body_mass_index | The body mass index of the donor. | string | no | | Body mass index | | 20.21; 27.5-32.5
ethnicity | Ethnicity of the donor. | array | no | [See module ethnicity_ontology](module.md#ethnicity-ontology) | Ethnicity | |

## Growth conditions<a name='Growth conditions'></a>
Expand Down
10 changes: 5 additions & 5 deletions json_schema/module/biomaterial/human_specific.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
},
"body_mass_index": {
"description": "The body mass index of the donor.",
"type": "number",
"maximum": 100,
"minimum": 5,
"example": 36.4,
"user_friendly": "Body mass index"
"type": "string",
"pattern": "^[0-1]?[0-9]{1,2}(\\.[0-9]+)?(-[0-1]?[0-9]{1,2}(\\.[0-9]+)?)?$",
"example": "20.21; 27.5-32.5",
"user_friendly": "Body mass index",
"guidelines": "Enter either a single value or a range of values. Indicate a range using a hyphen."
},
"ethnicity": {
"description": "Ethnicity of the donor.",
Expand Down
1 change: 1 addition & 0 deletions json_schema/update_log.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Schema,Change type,Change message,Version,Date
module/biomaterial/human_specific,major,Changed bmi pattern type to allow ranges,,
Loading