Skip to content

Adds Adipose tier2 fields#1638

Open
idazucchi wants to merge 40 commits intostagingfrom
iz-adipose-tier2
Open

Adds Adipose tier2 fields#1638
idazucchi wants to merge 40 commits intostagingfrom
iz-adipose-tier2

Conversation

@idazucchi
Copy link
Collaborator

@idazucchi idazucchi commented Dec 12, 2025

Release notes

This PR adds the tier 2 fields requested by the Adipose bionetwork (reference sheet here) - none of the fields added in this PR are required

New optional fields

For module/biomaterial/reproductive_history.json:

  • menstrual_cycle_stage

For module/biomaterial/blood_test.json:

  • androstenedione
  • androstenedione_unit
  • dhea
  • dhea_unit
  • estrogen
  • estrogen_unit
  • fasting_glucose
  • fasting_glucose_unit
  • fasting_insulin
  • fasting_insulin_unit
  • free_fatty_acid
  • free_fatty_acid_unit
  • haematocrit
  • haematocrit_unit
  • haemoglobin
  • haemoglobin_unit
  • hba1c
  • hba1c_unit
  • hdl
  • hdl_unit
  • homa_ir
  • ldl
  • ldl_unit
  • platelet_count
  • platelet_count_unit
  • shbg
  • shbg_unit
  • testosterone
  • testosterone_unit
  • triglycerides
  • triglycerides_unit
  • white_blood_cell_count
  • white_blood_cell_count_unit
  • bloodtest_time_offset
  • bloodtest_time_offset

For type/protocol/biomaterial_collection/collection_protocol.json :

  • biopsy_procedure

For type/biomaterial/specimen_from_organism.json :

  • experimental_condition
  • time_to_laboratory

For type/biomaterial/cell_suspension.json :

  • nuclei_yield

For module/biomaterial/medical_history.json :

  • fasting_time

For module/biomaterial/lifestyle.json :

  • physical_activity

For type/protocol/sequencing/library_preparation_protocol.json :

  • processing_time

For module/biomaterial/human_specific.json :

  • waist_circumference
  • waist_hip_ratio

Changes to existing fields

For module/biomaterial/human_specific.json:

  • body_mass_index : changed the type to string, extended validation to number range so it's still complatible with previous versions field

Reviews requested

Need 4 Reviewers to approve because this is a major update

Co-authored-by: Hannes Schmidt <hannes@ucsc.edu>
Copy link
Contributor

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can review again once the conflicts have been resolved.

@idazucchi idazucchi added the content Any PR that incorporates changes to the schema label Feb 18, 2026
Copy link
Contributor

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for being slow to respond. There are conflicts, still (or again). I will review again once the conflicts have been resolved.

@idazucchi
Copy link
Collaborator Author

Hi @hannes-ucsc!
I misunderstood your earlier comments about the unresolved conflicts, but I've resolved them now
I've also applied your regex suggestion to all the new fields that had a similar regex(body_mass_index, waist_circumference, waist_hip_ratio, time_to_laboratory), based on your comments on the Heart PR

Copy link
Contributor

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, previous review was meant to request changes.

idazucchi and others added 3 commits March 16, 2026 18:26
Co-authored-by: Hannes Schmidt <hannes@ucsc.edu>
Co-authored-by: Hannes Schmidt <hannes@ucsc.edu>
@idazucchi
Copy link
Collaborator Author

I've added ranges to the examples where relevant, as we've done for other fields like age

@idazucchi idazucchi requested a review from hannes-ucsc March 16, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Any PR that incorporates changes to the schema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants