Conversation
It's already part of the gut pr
json_schema/type/protocol/biomaterial_collection/collection_protocol.json
Outdated
Show resolved
Hide resolved
json_schema/type/protocol/sequencing/library_preparation_protocol.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Hannes Schmidt <hannes@ucsc.edu>
hannes-ucsc
left a comment
There was a problem hiding this comment.
I can review again once the conflicts have been resolved.
hannes-ucsc
left a comment
There was a problem hiding this comment.
Apologies for being slow to respond. There are conflicts, still (or again). I will review again once the conflicts have been resolved.
|
Hi @hannes-ucsc! |
hannes-ucsc
left a comment
There was a problem hiding this comment.
Sorry, previous review was meant to request changes.
Co-authored-by: Hannes Schmidt <hannes@ucsc.edu>
Co-authored-by: Hannes Schmidt <hannes@ucsc.edu>
|
I've added ranges to the examples where relevant, as we've done for other fields like age |
Release notes
This PR adds the tier 2 fields requested by the Adipose bionetwork (reference sheet here) - none of the fields added in this PR are required
New optional fields
For
module/biomaterial/reproductive_history.json:For
module/biomaterial/blood_test.json:For
type/protocol/biomaterial_collection/collection_protocol.json:For
type/biomaterial/specimen_from_organism.json:For
type/biomaterial/cell_suspension.json:For
module/biomaterial/medical_history.json:For
module/biomaterial/lifestyle.json:For
type/protocol/sequencing/library_preparation_protocol.json:For
module/biomaterial/human_specific.json:Changes to existing fields
For
module/biomaterial/human_specific.json:Reviews requested
Need 4 Reviewers to approve because this is a major update