Skip to content

fix: DIA-1986: New model providers don't bubble up task-level errors #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 6, 2025

Conversation

matt-bernstein
Copy link
Contributor

@matt-bernstein matt-bernstein commented Feb 28, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 24.27184% with 78 lines in your changes missing coverage. Please review.

Project coverage is 65.64%. Comparing base (4ada863) to head (baef8f6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
adala/utils/model_info_utils.py 19.44% 58 Missing ⚠️
adala/runtimes/_litellm.py 34.48% 19 Missing ⚠️
server/app.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   65.97%   65.64%   -0.34%     
==========================================
  Files          48       49       +1     
  Lines        2713     2739      +26     
==========================================
+ Hits         1790     1798       +8     
- Misses        923      941      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robot-ci-heartex robot-ci-heartex marked this pull request as draft March 1, 2025 08:06
@matt-bernstein matt-bernstein marked this pull request as ready for review March 5, 2025 01:58
@robot-ci-heartex robot-ci-heartex marked this pull request as draft March 5, 2025 12:09
@matt-bernstein matt-bernstein marked this pull request as ready for review March 5, 2025 13:20
@robot-ci-heartex robot-ci-heartex marked this pull request as draft March 6, 2025 07:06
@matt-bernstein matt-bernstein marked this pull request as ready for review March 6, 2025 13:35
@matt-bernstein matt-bernstein merged commit f43723f into master Mar 6, 2025
22 checks passed
@matt-bernstein matt-bernstein deleted the fb-dia-1986 branch March 6, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants