Skip to content

fix: DIA-1885: edge cases in string parsing #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2025
Merged

Conversation

matt-bernstein
Copy link
Contributor

Added new simpler string formatter with state. Should resolve errors in cost estimation, inference, refinement caused by weird prompt/tasks. See updated tests for new behavior.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.16%. Comparing base (4ada863) to head (60a7f61).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
adala/skills/collection/entity_extraction.py 85.71% 1 Missing ⚠️
adala/utils/parse.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   65.97%   66.16%   +0.18%     
==========================================
  Files          48       48              
  Lines        2713     2704       -9     
==========================================
- Hits         1790     1789       -1     
+ Misses        923      915       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-bernstein matt-bernstein requested a review from pakelley March 5, 2025 22:28
@robot-ci-heartex robot-ci-heartex marked this pull request as draft March 6, 2025 09:06
@matt-bernstein matt-bernstein marked this pull request as ready for review March 6, 2025 14:36
@matt-bernstein matt-bernstein merged commit 857b2a8 into master Mar 6, 2025
22 checks passed
@matt-bernstein matt-bernstein deleted the fb-dia-1885-2 branch March 6, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants