Skip to content

feat: DIA-1996: remove sync kafka library #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

matt-bernstein
Copy link
Contributor

Don't want to support 2 different libraries' formats for SSL, so to simplify implementation, use aiokafka for everything

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 12.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 70.01%. Comparing base (a20f2e6) to head (bb57fca).

Files with missing lines Patch % Lines
server/utils.py 12.50% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   70.23%   70.01%   -0.23%     
==========================================
  Files          51       51              
  Lines        2980     2991      +11     
==========================================
+ Hits         2093     2094       +1     
- Misses        887      897      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robot-ci-heartex robot-ci-heartex marked this pull request as draft April 16, 2025 10:06
@matt-bernstein matt-bernstein marked this pull request as ready for review April 16, 2025 14:05
@matt-bernstein matt-bernstein merged commit 2fcf3ec into master Apr 16, 2025
20 of 21 checks passed
@matt-bernstein matt-bernstein deleted the fb-dia-1996/remove-sync-kafka branch April 16, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants