Skip to content

Conversation

@benglewis
Copy link
Contributor

Description of the change

In my last PR, I realize now that I was a little hasty and did not implement the args support in the sidecarContainers correctly. This PR fixes the bugs there.

Benefits

Users of sideContainers like myself.

Possible drawbacks

N/A

Applicable issues

N/A.

I didn't open an issue ticket yet, but essentially this is the error that made me realize my mistake:

values don't meet the specifications of the schema(s) in the following chart(s):
    label-studio:
    - app.sidecarContainers.0.args: Invalid type. Expected: object, given: array

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Input Validation completed with values.schema.json.
  • Variables are documented in the values.yaml and added to the README.md.
  • Changelog updated to describe new changes/fixes.
  • Title of the pull request follows this pattern [heartex/<name_of_the_chart>] Descriptive title

@benglewis benglewis requested a review from a team as a code owner May 28, 2025 08:49
@benglewis
Copy link
Contributor Author

Closed in favor of #67

@benglewis benglewis closed this Jun 4, 2025
@benglewis benglewis deleted the sidecar-containers-args-fixes branch June 5, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant