-
Notifications
You must be signed in to change notification settings - Fork 320
fix: LSDV-4773: Undo history resets in MIG #1255
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1255 +/- ##
==========================================
+ Coverage 65.16% 65.51% +0.35%
==========================================
Files 411 411
Lines 25480 25491 +11
Branches 6561 6562 +1
==========================================
+ Hits 16604 16701 +97
+ Misses 8876 8790 -86
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
https://github.com/heartexlabs/label-studio-frontend/pull/1255/files#diff-fe7c98bf1c96a7516510c192b4c2d947adaef36b394240756f6d044b32eb2cc8R17 |
Co-authored-by: Sergey <[email protected]>
|
||
if (self.multiImage) { | ||
self.preloadImages(); | ||
self.disableHistoryReinit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it after preloadImage? As I understand it works just because history reset happens in a next tick, but we should not rely on this. And logically it should go first.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
LSDV-4773
What does this fix?
Fixes an issue when the undo history is reset if the user travels between images.
What is the new behavior?
The undo history is preserved between images.
What is the current behavior?
The undo history is reset if the user goes to a different image.
What libraries were added/updated?
None
Does this change affect performance?
No
Does this change affect security?
No
What alternative approaches were there?
None
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Labeling UI, Image Segmentation, MIG