Skip to content
This repository was archived by the owner on Apr 18, 2024. It is now read-only.

fix: LSDV-4773: Undo history resets in MIG #1255

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nick-skriabin
Copy link
Member

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

LSDV-4773

What does this fix?

Fixes an issue when the undo history is reset if the user travels between images.

What is the new behavior?

The undo history is preserved between images.

What is the current behavior?

The undo history is reset if the user goes to a different image.

What libraries were added/updated?

None

Does this change affect performance?

No

Does this change affect security?

No

What alternative approaches were there?

None

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Labeling UI, Image Segmentation, MIG

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.35 🎉

Comparison is base (8969ae4) 65.16% compared to head (e99c4c7) 65.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
+ Coverage   65.16%   65.51%   +0.35%     
==========================================
  Files         411      411              
  Lines       25480    25491      +11     
  Branches     6561     6562       +1     
==========================================
+ Hits        16604    16701      +97     
+ Misses       8876     8790      -86     
Impacted Files Coverage Δ
src/core/TimeTraveller.js 97.56% <100.00%> (+0.03%) ⬆️
src/tags/object/Image/Image.js 84.18% <100.00%> (+2.52%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gondragos
Copy link
Contributor


if (self.multiImage) {
self.preloadImages();
self.disableHistoryReinit();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it after preloadImage? As I understand it works just because history reset happens in a next tick, but we should not rely on this. And logically it should go first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants