This repository was archived by the owner on Apr 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
Change has impacts in these area(s)
(check all that apply)
What does this fix?
Bug was that drawing a polygon overlapping an existing one wasn't working properly. Even when pressing the 'ctrl' key to disable interactions, the existing polygon was getting selected/unselected at each click. This was because the 'skipInteraction' flag was set by the ctrl key, and then overwritten by the click (the Image model couldn't keep track if the interactions were to be skipped for multiple reasons at the same time).
With the fix, the Image model can keep track of multiple reasons for the interaction skip, therefore avoiding the flag to be overwritten.
In addition, I added the 'shouldSkipInteractions' in the polygon tool to skip interactions when we already started drawing a new polygon (preventing the need to hold the 'ctrl' key the whole time when drawing overlapping polygons).
Does this PR introduce a breaking change?
(check only one)