Skip to content
This repository was archived by the owner on Apr 18, 2024. It is now read-only.

chore: bump node-forge from 1.2.1 to 1.3.1 #692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 9, 2022

Bumps node-forge from 1.2.1 to 1.3.1.

Changelog

Sourced from node-forge's changelog.

1.3.1 - 2022-03-29

Fixes

  • RFC 3447 and RFC 8017 allow for optional DigestAlgorithm NULL parameters for sha* algorithms and require NULL paramters for md2 and md5 algorithms.

1.3.0 - 2022-03-17

Security

  • Three RSA PKCS#1 v1.5 signature verification issues were reported by Moosa Yahyazadeh ([email protected]).
  • HIGH: Leniency in checking digestAlgorithm structure can lead to signature forgery.
  • HIGH: Failing to check tailing garbage bytes can lead to signature forgery.
  • MEDIUM: Leniency in checking type octet.
    • DigestInfo is not properly checked for proper ASN.1 structure. This can lead to successful verification with signatures that contain invalid structures but a valid digest.
    • CVE ID: CVE-2022-24773
    • GHSA ID: GHSA-2r2c-g63r-vccr

Fixed

  • [asn1] Add fallback to pretty print invalid UTF8 data.
  • [asn1] fromDer is now more strict and will default to ensuring all input bytes are parsed or throw an error. A new option parseAllBytes can disable this behavior.
    • NOTE: The previous behavior is being changed since it can lead to security issues with crafted inputs. It is possible that code doing custom DER parsing may need to adapt to this new behavior and optional flag.
  • [rsa] Add and use a validator to check for proper structure of parsed ASN.1

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 9, 2022
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch from 6eedcd0 to 6dc5cc1 Compare November 29, 2022 15:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Patch and project coverage have no change.

Comparison is base (b00b0a3) 65.21% compared to head (c84f767) 65.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #692   +/-   ##
=======================================
  Coverage   65.21%   65.22%           
=======================================
  Files         411      411           
  Lines       25492    25492           
  Branches     6567     6567           
=======================================
+ Hits        16625    16627    +2     
+ Misses       8867     8865    -2     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch 4 times, most recently from bfcc63b to 1c9646d Compare November 29, 2022 20:02
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch 6 times, most recently from e04f462 to 66023a1 Compare December 19, 2022 10:18
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch from 66023a1 to fb4197b Compare December 20, 2022 17:35
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch 4 times, most recently from 75ca945 to 23caf3d Compare January 9, 2023 16:07
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch 3 times, most recently from 30dd082 to 53965b1 Compare January 30, 2023 10:40
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch from 53965b1 to 85e5849 Compare February 9, 2023 18:14
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch 2 times, most recently from 7c4895c to af2b555 Compare February 21, 2023 10:47
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch 4 times, most recently from 5aacba9 to 07d7abd Compare March 1, 2023 12:10
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch 2 times, most recently from 269078a to c84f767 Compare March 22, 2023 18:00
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch from c84f767 to 1143911 Compare March 29, 2023 11:41
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.2.1 to 1.3.1.
- [Release notes](https://github.com/digitalbazaar/forge/releases)
- [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md)
- [Commits](digitalbazaar/forge@v1.2.1...v1.3.1)

---
updated-dependencies:
- dependency-name: node-forge
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-forge-1.3.1 branch from 1143911 to 01619bf Compare April 13, 2023 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants