-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DIA-2075: [FE] Homepage projects list perf optimization #7281
Open
nick-skriabin
wants to merge
5
commits into
develop
Choose a base branch
from
fb-dia-2075/homepage-perf
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+64
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cn
and Badge
yyassi-heartex
approved these changes
Mar 25, 2025
bmartel
approved these changes
Mar 26, 2025
nass600
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving some components and utilities to
core
andui
to avoid using@humansignal/shad
directly.This pull request includes several changes to the
web/libs
directory aimed at enhancing the utility functions and re-exporting components for better modularity and reusability. The most important changes are as follows:Enhancements to utility functions:
web/libs/core/src/lib/utils/helpers.ts
: Exported thecn
function from@humansignal/ui/shad/utils/index
to facilitate smart merging of class names.web/libs/ui/src/shad/utils/index.ts
: Added a comment to document thecn
function, which smartly merges class names usingclsx
andtwMerge
.Re-exporting components for modularity:
web/libs/ui/src/index.ts
: Re-exported all components from theshadcn
module to make them available for use in other parts of the application.web/libs/ui/src/shadcn.ts
: Added re-exports forBadge
,BadgeProps
, andbadgeVariants
from./shad/components/ui/badge
to provide raw shadcn components for reuse.