fix: LEAP-2009: Respect granularity when resizing NER spans #7364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nass600
approved these changes
Apr 14, 2025
Otherwise it would hang the browser because of a very complex inner logic.
It fixes selection to point only to text nodes, so selection.move() will work properly. With non-text nodes it jumps into inner/outer nodes instead of shifting symbol by symbol.
Gondragos
approved these changes
Apr 17, 2025
|
/git merge
|
|
/fm sync |
|
/git merge
|
|
/fm sync |
Handles were messing up with ranges and selection, so we have to remove them earlier.
Gondragos
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to reuse the same funtionality we use in
captureSelection():trimSelection()(the secret sauce!) to fix selection to point only to text nodes;applyTextGranularity()to the selection expading it if neededWe need
trimSelection()so selection.move() will work properly.With non-text nodes it jumps into inner/outer nodes instead of shifting symbol by symbol.
Also set cursor to "resize" for the whole document during resize.