fix: LEAP-1947: Fix interactive view all FF in image tag case #7387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix interactive view all working with MIG approach - fix the way Tools Manager works in case of annotation has it's own independent tags models tree
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
|
/git merge
|
Gondragos
commented
Apr 21, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with interactive view rendering when working with image tags by integrating the FF_DEV_3391 feature flag. It also updates various modules to adjust tool manager behavior and annotation IDs for image-related entities.
- Enabled the FF_DEV_3391 feature flag in multiple files to conditionally change the rendering and tool initialization logic.
- Updates include modifications to ToolsManager, Tool mixins, and Annotation update functions to ensure IDs and tool references are handled correctly.
- Adjusted the Tree rendering logic to provide a fallback for image region rendering.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/libs/editor/src/tools/Manager.js | Added a new getter “root” intended to expose the annotation store’s root. |
| web/libs/editor/src/tags/object/Image/Image.js | Enhanced imageEntities ID generation and introduced a feature flag check in afterAttach. |
| web/libs/editor/src/stores/Annotation/Annotation.js | Extended updateIds to include imageEntities for consistency. |
| web/libs/editor/src/mixins/ToolManagerMixin.js | Added feature flag check in afterAttach to skip tool initialization when not applicable. |
| web/libs/editor/src/mixins/Tool.js | Updated obj and control getters to use the feature flag for annotation selection. |
| web/libs/editor/src/core/Tree.tsx | Modified rendering to use a fallback for image regions via a feature flag. |
Files not reviewed (1)
- web/libs/editor/src/core/feature-flags/flags.json: Language not supported
Comments suppressed due to low confidence (1)
web/libs/editor/src/tools/Manager.js:47
- The getter 'root' references an undefined variable 'root'. Consider using a properly defined reference, such as getRoot(this), or otherwise ensure that the root context is correctly passed.
return root;
hlomzik
approved these changes
Apr 22, 2025
Comment on lines
+572
to
+576
| .volatile((self) => { | ||
| return { | ||
| manager: null, | ||
| }; | ||
| }) |
There was a problem hiding this comment.
we usually use simpler version
Suggested change
| .volatile((self) => { | |
| return { | |
| manager: null, | |
| }; | |
| }) | |
| .volatile((self) => ({ | |
| manager: null, | |
| })) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to enable and integrate the
FF_DEV_3391feature flag, which enhances the handling of interactive views and image regions in the annotation tool.Feature Flag Integration:
FF_DEV_3391feature flag inflags.jsonto activate the new interactive view functionality.renderIteminTree.tsxto include a fallback mechanism (|| el) for rendering image regions when the feature flag is active.Tool and Manager Enhancements:
ToolMixinto dynamically adjust theobjandcontrolgetters based on the selected annotation. [1] [2]rootgetter inToolsManagerto provide access to the annotation store's root.Annotation and Image Model Updates:
Annotation.jsto includeimageEntitiesin theupdateIdsfunction for better handling of image-related annotations.Image.jsto: