fix: LEAP-1442: Fix unexpected scrolling on region select in Video #7392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user clicks on region label in Video timeline (left sidepanel of it), the video timeline scrolls to the left. That happens because click is treated as still a click on timeline but with negative offset outside of scrollable area, so it jumps to previous window.
Let's try to scroll to the first frame of the region on select.
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/git merge
|
Only scroll when user selects region in Outliner
…bel-studio into fb-leap-1442/video-scroll
Gondragos
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user clicks on region label in Video timeline (left sidepanel of it), the video timeline scrolls to the left.
That happens because click is treated as still a click on timeline but with negative offset outside of scrollable area, so it jumps to previous window.
Also scroll to the first frame of the region on select. That worked for VideoRectangle, so here is the same code for TimelineRegion.
@todois the same, because it's out of the current scope.