chore: FIT-1001: fix flakey tests #8834
Open
+233
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyassi-heartex
requested review from
hlomzik and
nick-skriabin
as code owners
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
❌ Deploy Preview for label-studio-storybook failed. Why did it fail? →
|
❌ Deploy Preview for label-studio-playground failed. Why did it fail? →
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #8834 +/- ##
============================================
- Coverage 66.72% 56.51% -10.22%
============================================
Files 811 554 -257
Lines 63432 40207 -23225
Branches 10690 10761 +71
============================================
- Hits 42325 22721 -19604
+ Misses 21104 17482 -3622
- Partials 3 4 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@yyassi-heartex Are the num of ticks premeditated in each instance? how would this affect performance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the reliability and determinism of end-to-end and integration tests across several test files by replacing arbitrary time-based waits (e.g.,
I.wait(1),cy.wait(500)) with more deterministic, animation-frame-based waits usingI.waitTicks. It also removes the.tag("@flakey")and.retry(3)markers from tests, signaling increased test stability. Additionally, some integration tests have been updated to ensure elements are interactable before proceeding, further reducing flakiness.Test Stability and Reliability Improvements
I.wait(1),cy.wait(500)) withI.waitTicks, which waits for a specific number of animation frames, making tests more deterministic and less prone to timing-related flakiness. This change was applied across audio region, paragraph-enhanced, video timeline, and sync audio test suites. [1] [2] [3] [4].tag("@flakey")and.retry(3)from all affected test scenarios, indicating that the tests are now considered stable and should not be retried automatically. [1] [2] [3] [4]Test Logic and Interaction Improvements
taxonomy-mig-per-item.cy.tsto ensure elements are fully rendered and interactable before attempting to interact with them, using visibility and enabled checks instead of arbitrary waits. This makes the tests more robust and less likely to fail due to rendering delays. [1] [2]Test Code Consistency
I.waitTicksand added comments to clarify the purpose of each wait, improving code readability and maintainability throughout the test suites. [1] [2] [3] [4] [5] [6] [7] [8]These changes collectively enhance the reliability, determinism, and maintainability of the automated test suite.