Skip to content

Conversation

@makseq
Copy link
Member

@makseq makseq commented Dec 30, 2025

Reason for change:
Removed the fflag_all_feat_bros_421_review_random_and_limit_tasks feature flag as requested. The flag was configured to always be TRUE and was not referenced by any runtime code, making its removal a cleanup.

Screenshots:
N/A - No visible changes.

Rollout strategy:
Direct merge. This is a configuration cleanup.

Testing:

  • read_lints label_studio/feature_flags.json was run and passed.
  • No automated tests were run as this is a configuration data change.
  • Consider a quick regression pass in any area that previously relied on review random/limit behavior if deemed necessary, though the flag was not actively used in code.

Risks:
Low risk, as the feature flag was not referenced in the application's runtime code, meaning its removal does not alter existing behavior.

Reviewer notes:
The flag fflag_all_feat_bros_421_review_random_and_limit_tasks was removed from label_studio/feature_flags.json. A search confirmed no code references this flag, so its removal is purely a cleanup.

General notes:
This change removes an unused feature flag entry from the feature_flags.json file.


Slack Thread

Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Dec 30, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit 377f70c
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/6953ea5c95f70700084de6fb

@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 377f70c
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/6953ea5c95f70700084de6f7

@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit 377f70c
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/6953ea5c613c8d000847fc3f

@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 377f70c
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/6953ea5c440e5c00082014f1

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.57%. Comparing base (f83bc53) to head (377f70c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9105       +/-   ##
============================================
+ Coverage    66.67%   81.57%   +14.89%     
============================================
  Files          832      271      -561     
  Lines        65114    24486    -40628     
  Branches     10988        0    -10988     
============================================
- Hits         43418    19974    -23444     
+ Misses       21692     4512    -17180     
+ Partials         4        0        -4     
Flag Coverage Δ
lsf-e2e ?
lsf-integration ?
lsf-unit ?
pytests 81.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants