feat: add Konkani locale parity - #1780
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds full Konkani (kok) locale: a comprehensive YAML locale file, many new expected rows across localization test matrices and docs, plus a new KonkaniLocaleTests suite exercising localization surfaces. ChangesKonkani Locale Support
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Adds Konkani (kok) locale parity by introducing locale YAML data and broad test matrix coverage across formatting, number words/parsing, ordinalization, dates, clocks, compass headings, and numeric formatting.
Changes:
- Added
kok.ymllocale definitions for generated Humanizer surfaces. - Added Konkani-specific exact-output tests.
- Extended shared locale theory/matrix data with
kokrows.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Humanizer/Locales/kok.yml |
Defines Konkani locale surfaces and generated profiles. |
tests/Humanizer.Tests/Localisation/kok/KonkaniLocaleTests.cs |
Adds locale-specific exact-output tests. |
tests/Humanizer.Tests/Localisation/LocaleCoverageData.cs |
Adds kok rows for shared coverage datasets. |
tests/Humanizer.Tests/Localisation/LocaleFormatterExactTheoryData.cs |
Adds formatter exact-output rows. |
tests/Humanizer.Tests/Localisation/LocaleNumberTheoryData.cs |
Adds number words, ordinal, gender, and parsing rows. |
tests/Humanizer.Tests/Localisation/LocaleNumberOverloadTheoryData.cs |
Adds overload test rows for large numbers. |
tests/Humanizer.Tests/Localisation/LocaleNumberMagnitudeTheoryData.cs |
Adds magnitude coverage rows. |
tests/Humanizer.Tests/Localisation/LocaleOrdinalizerMatrixData.cs |
Adds ordinalizer matrix rows. |
tests/Humanizer.Tests/Localisation/LocalePhraseTheoryData.cs |
Adds relative phrase and duration rows. |
Comments suppressed due to low confidence (2)
src/Humanizer/Locales/kok.yml:702
- The feminine numeric ordinalizer is missing the exact forms for 19 and 30, so it falls back to cardinal+suffix (
एकोणीसवी/तीसवी) instead of thenumber.words.ordinalformsएकोणीसावी/तिसावी.
20: 'विसावी'
21: 'एकविसावी'
32: 'बत्तीसावी'
100: 'शंबरावी'
src/Humanizer/Locales/kok.yml:719
- The neuter numeric ordinalizer is missing the exact forms for 19 and 30. This makes the fallback output
एकोणीसवें/तीसवें, which disagrees with thenumber.words.ordinalformsएकोणीसावें/तिसावें.
20: 'विसावें'
21: 'एकविसावें'
32: 'बत्तीसावें'
100: 'शंबरावें'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
kok) across formatter, phrases, number words/parsing, ordinal, clock, compass, calendar, and numeric formatting surfaces.Validation
dotnet test tests/Humanizer.SourceGenerators.Tests/Humanizer.SourceGenerators.Tests.csproj --framework net10.0dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net10.0dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net8.0dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net11.0dotnet pack src/Humanizer/Humanizer.csproj -c Release -o artifacts/locale-parity-validation -p:UseSharedCompilation=false -m:1dotnet format Humanizer.slnx --verify-no-changes --verbosity minimal