feat(locale): add Turkmen parity - #1781
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded a complete Turkmen (tk) locale YAML, a parity test suite validating Turkmen outputs, and inserted Turkmen rows into existing localization TheoryData across ordinals, numbers, durations, phrases, clock notation, compass labels, and byte-size formats. ChangesTurkmen Locale Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8daed91365
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds Turkmen (tk) locale support via YAML-backed localization data and expands locale parity/matrix tests to cover Turkmen formatting, numbers, ordinals, dates, clock, compass, and collection behavior.
Changes:
- Added
src/Humanizer/Locales/tk.ymlwith Turkmen locale surfaces. - Added Turkmen-specific parity tests.
- Added
tkrows across shared locale theory/matrix data.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Humanizer/Locales/tk.yml |
Defines Turkmen locale data for formatter, phrases, numbers, parsing, ordinals, clock, compass, and calendar months. |
tests/Humanizer.Tests/Localisation/tk/TurkmenLocaleParityTests.cs |
Adds exact-output Turkmen locale parity tests. |
tests/Humanizer.Tests/Localisation/LocalePhraseTheoryData.cs |
Adds Turkmen phrase/time span rows. |
tests/Humanizer.Tests/Localisation/LocaleOrdinalizerMatrixData.cs |
Adds Turkmen ordinalizer matrix rows. |
tests/Humanizer.Tests/Localisation/LocaleNumberTheoryData.cs |
Adds Turkmen number, ordinal, tuple, and parsing theory rows. |
tests/Humanizer.Tests/Localisation/LocaleNumberOverloadTheoryData.cs |
Adds Turkmen long-number overload rows. |
tests/Humanizer.Tests/Localisation/LocaleNumberMagnitudeTheoryData.cs |
Adds Turkmen magnitude/high-range number rows. |
tests/Humanizer.Tests/Localisation/LocaleFormatterExactTheoryData.cs |
Adds Turkmen exact formatter, byte size, list, and heading rows. |
tests/Humanizer.Tests/Localisation/LocaleCoverageData.cs |
Adds Turkmen rows required by shared locale coverage tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
tk) locale YAML parity across list, formatter/phrases, number words/parsing, ordinals, date/date-only, clock, compass, and calendar month surfaces.artifacts/2026-05-16-tk-parity-map.md(not committed).Validation
dotnet test tests/Humanizer.SourceGenerators.Tests/Humanizer.SourceGenerators.Tests.csproj --framework net10.0dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net10.0dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net8.0dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net11.0dotnet pack src/Humanizer/Humanizer.csproj -c Release -o artifacts/locale-parity-validationdotnet format Humanizer.slnx --verify-no-changes --verbosity minimal