Add Assamese locale parity - #1783
Merged
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (8)
📝 WalkthroughSummary by CodeRabbitNew Features
Documentation
WalkthroughAdds a full Assamese ( ChangesAssamese Locale Implementation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Assamese (as) locale support across Humanizer’s generated locale YAML, shared locale test matrices, and locale-specific exact-output tests.
Changes:
- Adds
src/Humanizer/Locales/as.ymlcovering phrases, formatter units, numbers, ordinals, parsing, compass, clock, and calendar data. - Extends shared locale theory/matrix data with Assamese expectations.
- Adds Assamese-focused tests for locale parity, number conversion, and ordinal behavior.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/Humanizer/Locales/as.yml |
Defines Assamese locale surfaces and generated behavior inputs. |
tests/Humanizer.Tests/Localisation/LocaleCoverageData.cs |
Adds Assamese rows to shared coverage matrices. |
tests/Humanizer.Tests/Localisation/LocaleFormatterExactTheoryData.cs |
Adds Assamese formatter/list/heading/data-unit expectations. |
tests/Humanizer.Tests/Localisation/LocaleNumberMagnitudeTheoryData.cs |
Adds Assamese magnitude number expectations. |
tests/Humanizer.Tests/Localisation/LocaleNumberOverloadTheoryData.cs |
Adds Assamese long-number overload expectations. |
tests/Humanizer.Tests/Localisation/LocaleNumberTheoryData.cs |
Adds Assamese cardinal, ordinal, tuple, and parsing expectations. |
tests/Humanizer.Tests/Localisation/LocaleOrdinalizerMatrixData.cs |
Adds Assamese ordinalizer matrix rows. |
tests/Humanizer.Tests/Localisation/LocalePhraseTheoryData.cs |
Adds Assamese phrase, null-date, and duration expectations. |
tests/Humanizer.Tests/Localisation/as/AssameseLocaleParityTests.cs |
Adds locale-specific parity tests for non-number surfaces. |
tests/Humanizer.Tests/Localisation/as/AssameseNumberToWordsTests.cs |
Adds Assamese number-to-words and words-to-number tests. |
tests/Humanizer.Tests/Localisation/as/AssameseOrdinalTests.cs |
Adds Assamese ordinal word and suffix tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Add Assamese (as) locale YAML across localized surfaces\n- Add Assamese exact-output tests for phrases, numbers, ordinals, dates, clock, compass, data/time units\n- Add Assamese entries to locale coverage and sweep matrices\n\n## Validation\n- dotnet test tests/Humanizer.SourceGenerators.Tests/Humanizer.SourceGenerators.Tests.csproj --framework net10.0: pass\n- dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net10.0: pass\n- dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net8.0: pass\n- dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net11.0: pass\n- dotnet pack src/Humanizer/Humanizer.csproj -c Release -o artifacts/locale-parity-validation: pass\n- dotnet format Humanizer.slnx --verify-no-changes --verbosity diagnostic: pass\n\n## Triage note\nEarlier net8/net11 PublicApiApprovalTest failures were not branch-caused; after removing stale received approval artifacts and rerunning against the current build, the targeted approval test and the full net8/net11 Humanizer.Tests suites pass.