Skip to content

test(docs): align production smoke with versioned heading - #1921

Merged
clairernovotny merged 2 commits into
mainfrom
codex/fix-production-smoke-homepage-heading
Aug 1, 2026
Merged

test(docs): align production smoke with versioned heading#1921
clairernovotny merged 2 commits into
mainfrom
codex/fix-production-smoke-homepage-heading

Conversation

@clairernovotny

Copy link
Copy Markdown
Member

Summary

Production smoke now distinguishes the versioned quick-start headings: stable 3.0.10 and 2.10.1 retain “Five-minute quick start,” while the v4 preview at /docs/next/ expects “Developer quick start.” Valid preview deployments no longer trigger rollback because of intentionally removed copy, and every route still verifies its exact page heading.

Related: https://github.com/Humanizr/Humanizer/actions/runs/30676212860

Validation

  • HUMANIZER_DOCS_EXPECTED_SHA=e997755055f3cede6f275d8a7c610386d1e44a96 pnpm --dir website run test:production — 1 passed against a fresh complete site build
  • pnpm --dir website run check:content
  • pnpm --dir website run test:unit — 54 passed
  • pnpm --dir website run typecheck
  • pnpm --dir website run build
  • pwsh tools/docs/build.ps1 -ValidateOnly
  • dotnet format Humanizer.slnx --verify-no-changes --verbosity diagnostic — 0 of 2,821 files changed
  • git diff --check

Checklist

  • Implementation is clean
  • Code adheres to the existing coding standards
  • No Code Analysis warnings
  • The production smoke regression itself provides focused coverage
  • No copied third-party code
  • No explanatory source comments were needed
  • XML documentation is not applicable to this test-only change
  • Branch is based on the latest main
  • Related failing workflow is linked above; no issue is closed by this test correction
  • README changes are not applicable
  • Applicable documentation gates were run

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f2de37cd-b14a-4c76-9600-5e55d25866b4

📥 Commits

Reviewing files that changed from the base of the PR and between 8b54dd7 and 03e8dd4.

📒 Files selected for processing (1)
  • website/tests/e2e/production.spec.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • website/tests/e2e/production.spec.ts

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated production end-to-end checks to validate the correct headings across current, versioned, and next quick-start pages.

Walkthrough

The production E2E test now validates route-specific headings for current, versioned, and next quick-start pages.

Changes

Quick-start heading assertions

Layer / File(s) Summary
Route-specific heading validation
website/tests/e2e/production.spec.ts
The test expects “Developer quick start” for the next-version page and “Five-minute quick start” for the other quick-start pages.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A rabbit checks each page with care,
“Developer quick start” appears there.
Current paths show their title right,
Versioned headings match in sight.
Quick-start tests now hop just so.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the production smoke test update for version-specific documentation headings.
Description check ✅ Passed The description directly explains the version-specific headings, affected route, and validation performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-production-smoke-homepage-heading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@website/tests/e2e/production.spec.ts`:
- Around line 52-54: Update the quick-start expectation in the versioned
headings configuration to match the current route’s exact heading, “Developer
quick start,” or enable exact heading-name validation for every entry so
inclusive matching cannot produce false positives.
- Around line 68-69: Update the heading locator in the production smoke test’s
page expectation to pass exact: true alongside expected.heading, ensuring the
assertion only matches a heading whose accessible name equals the expected
value.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 29684312-37f6-477c-acfb-037437d032d6

📥 Commits

Reviewing files that changed from the base of the PR and between e997755 and 8b54dd7.

📒 Files selected for processing (1)
  • website/tests/e2e/production.spec.ts

Comment thread website/tests/e2e/production.spec.ts
Comment thread website/tests/e2e/production.spec.ts Outdated
@clairernovotny
clairernovotny merged commit 1fb65d7 into main Aug 1, 2026
17 checks passed
@clairernovotny
clairernovotny deleted the codex/fix-production-smoke-homepage-heading branch August 1, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant