test(docs): align production smoke with versioned heading - #1921
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe production E2E test now validates route-specific headings for current, versioned, and next quick-start pages. ChangesQuick-start heading assertions
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@website/tests/e2e/production.spec.ts`:
- Around line 52-54: Update the quick-start expectation in the versioned
headings configuration to match the current route’s exact heading, “Developer
quick start,” or enable exact heading-name validation for every entry so
inclusive matching cannot produce false positives.
- Around line 68-69: Update the heading locator in the production smoke test’s
page expectation to pass exact: true alongside expected.heading, ensuring the
assertion only matches a heading whose accessible name equals the expected
value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 29684312-37f6-477c-acfb-037437d032d6
📒 Files selected for processing (1)
website/tests/e2e/production.spec.ts
Summary
Production smoke now distinguishes the versioned quick-start headings: stable 3.0.10 and 2.10.1 retain “Five-minute quick start,” while the v4 preview at
/docs/next/expects “Developer quick start.” Valid preview deployments no longer trigger rollback because of intentionally removed copy, and every route still verifies its exact page heading.Related: https://github.com/Humanizr/Humanizer/actions/runs/30676212860
Validation
HUMANIZER_DOCS_EXPECTED_SHA=e997755055f3cede6f275d8a7c610386d1e44a96 pnpm --dir website run test:production— 1 passed against a fresh complete site buildpnpm --dir website run check:contentpnpm --dir website run test:unit— 54 passedpnpm --dir website run typecheckpnpm --dir website run buildpwsh tools/docs/build.ps1 -ValidateOnlydotnet format Humanizer.slnx --verify-no-changes --verbosity diagnostic— 0 of 2,821 files changedgit diff --checkChecklist
main