Ship javascript, not binaries #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#!/usr/bin/env nodeat the top of index.ts and ship an index.js with the bundled Javascript for the entire CLI.Downside of this: bun's startup time is faster so now the CLI will boot up a little slower when the user types a command.
Upside of this: we are essentially opting out of handling platform cross-compatibility ourselves, all we now rely upon is the user having a supported
nodebinary somewhere on their system (which is pretty likely if they installed us vianpm install @humeai/cli)Tested via
npm run prebuild && dist/index.js tts "Hello"on both Linux and Mac.