Symfony64 1 #2
Open
Symfony64 1 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ignoreTag` option was added specifically for this use case. See also: - https://formatjs.io/docs/intl-messageformat/#intlmessageformat-constructor - formatjs/formatjs#1699
The filter "raw" is necessary to encode language with subtags in javascript file, otherwise there is an error on locale code ("en\u002DUS" for example).
This also avoids a deprecation notice from composer when generating an optimized autoloader due to the fixture app of the tests not following the PSR-4 convention configured for sources (while being in a subfolder)
* Remove 'app' from DumpCommand path app path does not longer exists since sf4 * Rename kernelRootDir to projectDir in DumpCommand
* Upgrade the JS testsuite to use QUnit 2 This uses npm to install the testsuite dependencies instead of vendoring them in the project to make the setup easier to maintain. This also removes the file loading the ES5-shim as all maintained browsers support ES5 natively anyway. * Modernize the UMD structure for the translator * Replace the test runner for JS tests PhantomJS is not maintained anymore and the setup was broken. The new setup uses `@web/test-runner` to run the QUnit tests in an actual browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.