Skip to content

feat: DanDaDan by aasaaDev#112

Closed
aasaaDev wants to merge 1 commit into
HyDE-Project:masterfrom
aasaaDev:master
Closed

feat: DanDaDan by aasaaDev#112
aasaaDev wants to merge 1 commit into
HyDE-Project:masterfrom
aasaaDev:master

Conversation

@aasaaDev

@aasaaDev aasaaDev commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Description

Addition of theme to Gallery

Linked Issues

Additional context

  • PR title follows naming conventions (e.g., feat(theme):, fix(theme):)
  • PR description clearly explains the purpose of the changes
  • Related issues are linked (if any)
  • Screenshots are included
  • Screenshot size smaller than 4 MB (https://www.iloveimg.com/compress-image for compression)
  • Affected components/pages are listed
  • No unrelated changes are included

Summary by CodeRabbit

  • New Features

    • Added DanDaDan theme to the HyDE theme gallery.
  • Documentation

    • Updated theme gallery showcase with refreshed preview assets and links across multiple themes.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds a new "DanDaDan" theme to the HyDE theme gallery. The change registers the theme in the JSON data file, updates the gallery documentation header to reflect 64 worlds instead of 63, inserts the new theme's gallery display section, renumbers all 49 subsequent existing themes, and refreshes preview image and badge asset links for 10 affected themes.

Changes

New Theme Addition

Layer / File(s) Summary
Theme metadata registration
hyde-themes.json
DanDaDan theme entry added with LINK, OWNER, DESCRIPTION, and COLORSCHEME fields.
Gallery table and header update
README.md
Gallery count incremented from 63 to 64 worlds in the header; DanDaDan added to the main theme index table.
DanDaDan gallery display section
README.md
Full gallery entry section for DanDaDan inserted with preview image placeholder, theme description, and back-to-top badge anchor.
Existing theme renumbering and asset updates
README.md
All 49 subsequent theme indices incremented by 1; preview image and badge asset links refreshed for Abyssal-Wave, BlueSky, Catppuccin Mocha, Code Garden, Edge Runner, Gruvbox Retro, Material Sakura, Nightbrew, Paranoid Sweet, Solarized Dark, and Tokyo Night.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • HyDE-Project/hyde-gallery#111: Both PRs modify README.md gallery ordering and hyde-themes.json theme entries, using the same theme-gallery data structures and renumbering existing themes.
  • HyDE-Project/hyde-gallery#110: Both PRs add a new theme to hyde-themes.json and regenerate README.md gallery sections, including gallery count updates and overlapping preview/badge asset link changes.

Suggested reviewers

  • Maroc02
  • saber-88

Poem

🐰 A new world joins the gallery bright,
DanDaDan shines with pixel-perfect light!
Forty-nine themes shift by one degree,
While preview assets dance in harmony.
Sixty-four worlds now for all to see! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a new DanDaDan theme by aasaaDev to the gallery, which is reflected in both README.md and hyde-themes.json updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aasaaDev

aasaaDev commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

I'm still trying to get a hang of things, feel free to comment changes to be made

@kRHYME7

kRHYME7 commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator
image

The theme should have sources like these, and named accordingly.
https://github.com/HyDE-Project/hyde-themes/tree/Catppuccin-Mocha/Source

@aasaaDev

aasaaDev commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

so the fix here is rebuild the theme with those sources inside and reup it, right?
I've also had problems creating the readme with the script, clonning the starter repo doesn't come with themes.json file, so I'm not sure if what I did to fetch it was right #113

@aasaaDev

aasaaDev commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Everything should be fixed now!

@aasaaDev aasaaDev closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants