-
Notifications
You must be signed in to change notification settings - Fork 7
Add Endpoint for Turbine Changes and Tests #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Endpoint for Turbine Changes and Tests #127
Conversation
Create test
Add delete turbines with name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be helpful, and it doesn't have to be part of this pull request, to add an example notebook similar to the ratings one under the examples folder. To show how each of these "regi" endpoints work. Can include some of the other endpoints as well for locks, ect. This would also allow you to test the endpoints against cwbi-test to make sure they are working correctly and using the correct urls/parameters. If you are unable to do that maybe we can fund someone at SWT, SWF, or another district to put that together.
Fix path vs param issues on endpoints
looks like 2 test failed. =========================== short test summary info ============================ |
|
This PR is for
It adds the endpoints seen here for turbine-changes:
https://cwms-data.usace.army.mil/cwms-data/swagger-ui.html
Patch is the only endpoint I did not add.
Why I marked this as a draft
I am uncertain of the function names.
I tried to keep them similar to cwmsjs seen here:
While not a cwms-python issue, these names are generated this way and are.. descriptive despite being long.
I'm open to change on these to enforce the cwms-python naming if we have preference.
Tests
Added json resources and ran various pytests