Turbine Changes Require List POST #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Enovotny
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint
/swt-data/projects/{office}/{name}/turbine-changesRequires a List to store.
We attempted to store using a dictionary/Object and got a serialization error.
Error :
Suggesting it is trying to use an Array but an Object was provided
In this PR I update the post and patch in the API methods to allow for a
Listto be provided.I confirmed this works by manually editing the library on @AndySWT computer and we successfully saved a turbine change.
I did consider putting
JSONas the type check, but that appears to be of type[dict, Any]and could cause issues.