⬆️ Upgrade bb version #1144
Merged
⬆️ Upgrade bb version #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. |
wraitii
approved these changes
May 6, 2025
BertrandD
requested changes
May 6, 2025
| @@ -2,14 +2,11 @@ FROM rust:alpine AS builder | |||
| RUN apk add gcc musl-dev g++ | |||
| RUN cargo install --version 2.0.0 risc0-r0vm | |||
|
|
|||
| FROM alpine:latest | |||
| FROM ubuntu:24.04 | |||
There was a problem hiding this comment.
Toute l'idée de ce Dockerfile ( nommé .alpine) c'est de pouvoir partir d'une base alpine et d'y builder les dépendances dont on a besoin pour pouvoir utiliser alpine comme base de hyle. Si on met ubuntu ici, autant basarder le fichier et installer r0vm & bbup directement dans le Dockerfile principal, mais je trouve ça dommage
BertrandD
approved these changes
May 12, 2025
BertrandD
added a commit
that referenced
this pull request
May 12, 2025
This reverts commit 00c19b0.
BertrandD
added a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.