⚡️ Process buffered DP when done with one #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the buffered DataProposals processing to ensure that a descendant proposal is processed once its parent has been hashed. Key changes include logging the buffering of a DataProposal, checking for a buffered descendant proposal, and processing that descendant accordingly.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
|
BertrandD
reviewed
May 12, 2025
This avoids a situation where we receive several DPS, and by the time the hashing of the second is done we haven't done processing the first. We'd buffer it and just forget about it.
Co-authored-by: Copilot <[email protected]>
wraitii
force-pushed
the
process_bufferred
branch
from
d7bcafd to
48cba00
Compare
hhalex
approved these changes
May 12, 2025
wraitii
force-pushed
the
process_bufferred
branch
from
0aed9ea to
7406af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a situation where we receive several DPS, and by the time the hashing of the second is done we haven't done processing the first. We'd buffer it and just forget about it.