Conversation
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 38.20% 38.16% -0.04%
==========================================
Files 69 69
Lines 3942 3946 +4
==========================================
Hits 1506 1506
- Misses 2436 2440 +4
Continue to review full report at Codecov.
|
mifrandir
left a comment
mifrandir
left a comment
There was a problem hiding this comment.
Small things; good stuff otherwise!
|
|
||
| // set clock frequency | ||
| setClock(Clock::k1MHz); | ||
| setClock(Clock::k500KHz); |
There was a problem hiding this comment.
Is this required? Did we test it? Has it to do with the new IMUs?
There was a problem hiding this comment.
Yes, yes and yes. Although this just needs to be tested with the sensors PCB but with an individual IMU, this worked.
| int fd; | ||
| uint32_t len; | ||
| fd = open("/sys/class/gpio/export", O_WRONLY); | ||
| fd = open("/sys/class/gpio/export", O_RDWR); |
There was a problem hiding this comment.
You've touched this line now so we need to do this properly.
const auto fd = open(/* ... */);Similar for len.
4 participants
Slight modifications which gets the IMU-20948 to work with our code on the beagleboneblack.
Giving read and write permissions when opening gpio export file to prevent consistent export errors.