[Fix] Remove get folder parent util fxn, prevent text input in install modal path field #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This closes #672
waiting for upstream PR merge here Alex-D/check-disk-space#29
Background
https://github.com/Alex-D/check-disk-space is used by both Heroic and HyperPlay to check available disk space. The
getFirstExistingParentPath
function was copied from this package into the utils file on this PR Heroic-Games-Launcher/HeroicGamesLauncher#1575. This function is now duplicated in 3 places, in the original package, in heroic utils, and in hyperplay utils.There is a bug when checking disk space for
Z:
where Z is a non-existent drive on windows #672. The function gets caught in an infinite while loop and crashes HyperPlay. Because the InstallModal install path text field was editable, a user could type this out in the text field and (since disk space is calculated after every keystroke) this would crash HyperPlay.This PR
getFirstExistingParentPath
back into the@hyperplay/check-disk-usage
package until an upstream PR is acceptedcheck-disk-usage