Skip to content

KeycloakConfig retrieval should use the sslContext#2280

Draft
diegolovison wants to merge 1 commit into
Hyperfoil:masterfrom
diegolovison:ssl_context
Draft

KeycloakConfig retrieval should use the sslContext#2280
diegolovison wants to merge 1 commit into
Hyperfoil:masterfrom
diegolovison:ssl_context

Conversation

@diegolovison
Copy link
Copy Markdown
Contributor

Changes proposed

All http requests should use the sslContext configured

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr lampajr self-requested a review February 26, 2025 08:15
Copy link
Copy Markdown
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @diegolovison, thanks for the fix.

Overall looks good but can you please add a test that ensure the behavior would be the expected one, if possible? For instance here https://github.com/Hyperfoil/Horreum/blob/d437b3652b8414ab6b5bab878772a0e110df0279/horreum-integration-tests/src/test/java/io/hyperfoil/tools/horreum/it/HorreumClientIT.java where we have all the tests using the HorreumClient

@diegolovison
Copy link
Copy Markdown
Contributor Author

Let me think about the test.

@diegolovison diegolovison marked this pull request as draft February 26, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants