Support huge JSON data#2286
Conversation
There was a problem hiding this comment.
Hi @diegolovison, I did some tests and the changes are actually fixing the problem of uploading a big run but TBH I don't think we should set such defaults here.
Both can be added where needed at runtime (and if and only if are needed):
- Server side:
quarkus.http.limits.max-body-size=300Mcan be passed as JVM option when starting the server (i.e., we can do that in out internal lab for instance) - Client side:
org.jboss.resteasy.client.jaxrs.engines.fileUploadInMemoryThresholdcan be set before creating theHorreumClient, so that if users need that can do on their own and have a way to configure it. If we hardcode that users CANNOT override that value
what is the limit on the database? |
Don't remember exactly (need to check), but we should try to keep the json objects as smaller as possible for performance reasons.. therefore I would prefer to keep a lower limit by default - that's why I don't think increasing the quarkus max body limit is the good choice here (at least for the defaults) |
|
As agreed this is going to be updated to become a new guide section or paragraph showing how users can deal with big JSON data. @diegolovison converting this back to draft but feel free to close this one and open a new one if you consider so. |
Changes proposed
Support huge JSON data
Check List (Check all the applicable boxes)