Skip to content

Bump react to 19#2488

Merged
lampajr merged 13 commits intoHyperfoil:masterfrom
barreiro:react-19
Sep 23, 2025
Merged

Bump react to 19#2488
lampajr merged 13 commits intoHyperfoil:masterfrom
barreiro:react-19

Conversation

@barreiro
Copy link
Collaborator

this pr updates react to version 19 and the necessary dependencies.

patternfly-templates does not support the update, so I'm bringing those components that Horreum uses into the codebase, for now.

react-table update has breaking changes on the API, so there are major changes in CustomTableand it's usages.

@stalep
Copy link
Member

stalep commented Sep 18, 2025

As part of this work (or a separate) task, can we also have a look at #2314 for v0.19? @barreiro @lampajr ?

@lampajr
Copy link
Member

lampajr commented Sep 18, 2025

As part of this work (or a separate) task, can we also have a look at #2314 for v0.19? @barreiro @lampajr ?

I believe it would be nice to include that fix in the next release and if the fix is simple enough maybe it is better to include it here

@barreiro
Copy link
Collaborator Author

I'll have a look. will do a separate request for it with the fix.

@lampajr
Copy link
Member

lampajr commented Sep 22, 2025

patternfly-templates does not support the update, so I'm bringing those components that Horreum uses into the codebase, for now.

@barreiro with regard to this, have you checked whether they are planning to support that or not? If not, do you see other alternatives instead of "copying" those templates in this codebase?

[edit] I mean for now it's fine to keep them here, I was just trying to see in the long term

@barreiro
Copy link
Collaborator Author

patternfly-templates does not support the update, so I'm bringing those components that Horreum uses into the codebase, for now.

@barreiro with regard to this, have you checked whether they are planning to support that or not? If not, do you see other alternatives instead of "copying" those templates in this codebase?

@lampajr I have filled patternfly/patternfly-react#12014 so that is tracked by the Patternfly team.

Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did many smoke tests using the prof backup and all looks good to me, I did not spot anything broken atm!

@lampajr lampajr merged commit 62dcc6c into Hyperfoil:master Sep 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants