Fix out-of-bounds decimals() generation#4747
Merged
Merged
Conversation
Compute the integer bounds for fixed-point decimals exactly with Fraction. Previously they were derived via a limited-precision Context.divide whose precision was based only on the integer-part magnitude, so bounds with more fractional digits than `places` could round during the division and make ceil/floor over- or undershoot, yielding values outside min_value/max_value. https://claude.ai/code/session_01PaoeogHgq8MwBbXGi5kP4v
Liam-DeVoe
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute the integer bounds for fixed-point decimals exactly with Fraction. Previously they were derived via a limited-precision Context.divide whose precision was based only on the integer-part magnitude, so bounds with more fractional digits than
placescould round during the division and make ceil/floor over- or undershoot, yielding values outside min_value/max_value.Fixes #4651.