Split explain-phase statistics out of shrink phase#4750
Merged
Zac-HD merged 3 commits intoMay 27, 2026
Conversation
Previously the explain phase ran inside the shrink phase's statistics context, so its runtime and test cases were folded into the shrink phase and a slow explain phase looked like slow shrinking. Make phase logging nestable so explain gets its own bucket, with the shrink phase excluding nested explain time. https://claude.ai/code/session_01Fc3MJNwp5dLDCxTYjkFrVT
Move the type: ignore onto the non-literal key argument so mypy suppresses the misc error there rather than flagging an unused ignore. https://claude.ai/code/session_01Fc3MJNwp5dLDCxTYjkFrVT
Liam-DeVoe
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the explain phase ran inside the shrink phase's statistics context, so its runtime and test cases were folded into the shrink phase and a slow explain phase looked like slow shrinking. Make phase logging nestable so explain gets its own bucket, with the shrink phase excluding nested explain time.
Closes #4179.