Support from_dtype(numpy.dtypes.StringDType)#4756
Merged
Zac-HD merged 1 commit intoMay 28, 2026
Merged
Conversation
Zac-HD
force-pushed
the
claude/hopeful-einstein-zhwDO
branch
3 times, most recently
from
bff3770 to
369e2f9
Compare
Liam-DeVoe
approved these changes
May 28, 2026
Zac-HD
force-pushed
the
claude/hopeful-einstein-zhwDO
branch
from
369e2f9 to
748f3f5
Compare
from_dtype now natively supports numpy 2.0+ variable-width strings (StringDType, kind 'T'), generating arbitrary strings via text(). Passing a dtype class such as np.dtypes.StringDType where an instance was expected now raises a clear error, instead of the previous confusing message (or silent coercion to the object dtype in arrays).
Zac-HD
force-pushed
the
claude/hopeful-einstein-zhwDO
branch
from
748f3f5 to
6cc9c3c
Compare
Contributor
|
Thank you! I'm glad it was straightforward to support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4039.